[PATCH] riched20: fixed pointer to value out of scope (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Aug 18 04:56:12 CDT 2012


We need this array one scope higher up for ME_InsertTextFromCursor,
the compiler could overwrite it otherwise.

(see pText = wszText)

CID 715797
---
 dlls/riched20/editor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c
index 18cd159..6221f4b 100644
--- a/dlls/riched20/editor.c
+++ b/dlls/riched20/editor.c
@@ -292,6 +292,7 @@ static LRESULT ME_StreamInText(ME_TextEditor *editor, DWORD dwFormat, ME_InStrea
 
   do {
     LONG nWideChars = 0;
+    WCHAR wszText[STREAMIN_BUFFER_SIZE+1];
 
     if (!stream->dwSize)
     {
@@ -305,7 +306,6 @@ static LRESULT ME_StreamInText(ME_TextEditor *editor, DWORD dwFormat, ME_InStrea
 
     if (!(dwFormat & SF_UNICODE))
     {
-      WCHAR wszText[STREAMIN_BUFFER_SIZE+1];
       char * buf = stream->buffer;
       DWORD size = stream->dwSize;
       DWORD cp = CP_ACP;
-- 
1.7.3.4




More information about the wine-patches mailing list