winemaker: Output UTF-8 Makefiles

André Hentschel nerv at
Mon Dec 3 12:46:44 CST 2012

A user reported he had issues with that, i did some tests.
"use utf8;" indicates the source of winemaker is utf-8.
I didn't used "binmode( FILEO, ':utf8' );" for changed sourcefiles, because we should read and write them as they are and our changes shouldn't be utf-8 specific.
We could mess them up if we try to read unknown encoding and write utf-8, i guess we don't want to convert that.
 tools/winemaker | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/winemaker b/tools/winemaker
index 7cc9409..443bf3a 100755
--- a/tools/winemaker
+++ b/tools/winemaker
@@ -1,4 +1,5 @@
 #!/usr/bin/perl -w
+use utf8;
 use strict;
 # Copyright 2000-2004 Francois Gouget for CodeWeavers
@@ -2390,6 +2391,7 @@ sub generate_project_files($)
     print STDERR "       $!\n";
+  binmode( FILEO, ':utf8' );
   my $cpp_to_object;
   if (@$project_settings[$T_FLAGS] & $TF_HASCXX) {


Best Regards, André Hentschel

More information about the wine-patches mailing list