testbot/TestAgent: Fix the Ping() RPC.

Francois Gouget fgouget at codeweavers.com
Thu Dec 6 13:58:12 CST 2012


It's not used for the connection setup so it can be implemented normally.
---
 testbot/lib/WineTestBot/TestAgent.pm |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm
index 08c19cd..6461f5a 100644
--- a/testbot/lib/WineTestBot/TestAgent.pm
+++ b/testbot/lib/WineTestBot/TestAgent.pm
@@ -863,16 +863,6 @@ sub _Connect($)
   return 1;
 }
 
-sub _Ping($)
-{
-  my ($self) = @_;
-
-  # Send the RPC and get the reply
-  return $self->_SendRawUInt32($RPC_PING) &&
-         $self->_SendListSize(0) &&
-         $self->_RecvList('');
-}
-
 sub _StartRPC($$)
 {
   my ($self, $RpcId) = @_;
@@ -907,7 +897,11 @@ sub _StartRPC($$)
 sub Ping($)
 {
   my ($self) = @_;
-  return $self->_StartRPC($RPC_PING);
+
+  # Send the RPC and get the reply
+  return $self->_StartRPC($RPC_PING) &&
+         $self->_SendListSize(0) &&
+         $self->_RecvList('');
 }
 
 sub GetVersion($)
-- 
1.7.10.4




More information about the wine-patches mailing list