testbot/TestAgent: Remove some unneeded checks for a broken connection.

Francois Gouget fgouget at codeweavers.com
Thu Dec 6 14:01:13 CST 2012


These checks are redundant with the first recv_xxx() or send_xxx() call these functions make (only send_file() is a slightly special case).
---
 testbot/src/testagentd/testagentd.c |   12 ------------
 1 file changed, 12 deletions(-)

diff --git a/testbot/src/testagentd/testagentd.c b/testbot/src/testagentd/testagentd.c
index 607c776..a548491 100644
--- a/testbot/src/testagentd/testagentd.c
+++ b/testbot/src/testagentd/testagentd.c
@@ -217,9 +217,6 @@ static int recv_raw_data(SOCKET client, void* data, uint64_t size)
 
 static int recv_raw_uint32(SOCKET client, uint32_t *u32)
 {
-    if (broken)
-        return 0;
-
     if (!recv_raw_data(client, u32, sizeof(*u32)))
         return 0;
     *u32 = ntohl(*u32);
@@ -230,9 +227,6 @@ static int recv_raw_uint64(SOCKET client, uint64_t *u64)
 {
     uint32_t high, low;
 
-    if (broken)
-        return 0;
-
     if (!recv_raw_uint32(client, &high) || !recv_raw_uint32(client, &low))
         return 0;
     *u64 = ((uint64_t)high) << 32 | low;
@@ -246,9 +240,6 @@ static int recv_raw_uint64(SOCKET client, uint64_t *u64)
 
 static int recv_entry_header(SOCKET client, char *type, uint64_t *size)
 {
-    if (broken)
-        return 0;
-
     return recv_raw_data(client, type, sizeof(*type)) &&
            recv_raw_uint64(client, size);
 }
@@ -261,9 +252,6 @@ static int expect_entry_header(SOCKET client, char type, uint64_t *size)
     uint64_t hsize;
     int success;
 
-    if (broken)
-        return 0;
-
     if (!recv_entry_header(client, &htype, &hsize))
         return 0;
 
-- 
1.7.10.4



More information about the wine-patches mailing list