[PATCH 2/2] winmm/tests: Test some inconsistent WAVEFORMAT descriptions.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Thu Jan 5 03:38:51 CST 2012


Back in 2009, I reported that I had listened native winmm correctly play .wav with broken nBlockAlign and AvgBytes.

Now is the time to add these tests. One annoyance is that we already have machines that
time out because the wave tests take more than 30 seconds when several sound cards
are present.  Adding tests is not going to improve upon the situation.

What we need is a rewrite of wave.c to
1. choose a supported format instead of hard-coded 22050x16x2 or some such;
2. get rid of lots of ret==WAVERR_* etc. once a known working base format was chosen.
3. revisit the duration of some things played
4. revise log output. Iin case of failure, you don't know which format lead to failure,
    that's why I used 2.0 seconds in the present tests: 2.0 was easily identifiable.

We also need to add
a) ValidBits etc. tests
Any takers?

 Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-winmm-tests-Test-some-inconsistent-WAVEFORMAT-descr.patch
Type: application/octet-stream
Size: 4091 bytes
Desc: 0003-winmm-tests-Test-some-inconsistent-WAVEFORMAT-descr.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20120105/3fa09b98/attachment-0001.obj>

More information about the wine-patches mailing list