dsound: Vista/XP SP2 reworked the Speaker Configuration.
Joerg-Cyril.Hoehle at t-systems.com
Joerg-Cyril.Hoehle at t-systems.com
Thu Jan 12 02:26:05 CST 2012
Hi,
For reference, see
http://msdn.microsoft.com/en-us/library/windows/hardware/ff536440%28v=vs.85%29.aspx
http://msdn.microsoft.com/en-us/library/windows/hardware/ff537511%28v=VS.85%29.aspx
and the 2-3 pages references from there.
- return KSAUDIO_SPEAKER_7POINT1; /* not 7POINT1_SURROUND */
+ return KSAUDIO_SPEAKER_7POINT1_SURROUND; /* Vista deprecates 7POINT1 */
I'm sorry to revisit a revious patch of mine. IIRC the old code came from looking
at the source code of some free players which apparently have not been modernized
-- or deliberately choose to keep the old values.
+ device->speaker_config = DSSPEAKER_COMBINED(DSSPEAKER_STEREO, DSSPEAKER_GEOMETRY_WIDE);
Look up test.winehq Vista/w7 dsound logs and you'll see that's what they
return as the original, unmodifiable speaker position.
Incidentally, I believe the current mmdevapi channel checking code is broken
if (supplied.dwchannelmask == default_channel_mask_for(supplied.nChannels))
is not an appropriate check with multi-channel. Wine should accept different dwChannelMask.
Perhaps I should open a bug report about it, but by what criteria would it eventually be closed?
Regards,
Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsound-Vista-XP-SP2-reworked-the-Speaker-Configurat.patch
Type: application/octet-stream
Size: 4955 bytes
Desc: 0001-dsound-Vista-XP-SP2-reworked-the-Speaker-Configurat.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20120112/09865287/attachment-0001.obj>
More information about the wine-patches
mailing list