windowscodecs: Fix memory deallocation in LoadUnknownMetadata (Coverity)

Frédéric Delanoy frederic.delanoy at gmail.com
Sat Jan 14 17:35:47 CST 2012


A bad condition was used when memory allocation failed

CID 5522
---
 dlls/windowscodecs/metadatahandler.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c
index 23854d8..f1e9884 100644
--- a/dlls/windowscodecs/metadatahandler.c
+++ b/dlls/windowscodecs/metadatahandler.c
@@ -556,7 +556,7 @@ static HRESULT LoadUnknownMetadata(IStream *input, const GUID *preferred_vendor,
     }
 
     result = HeapAlloc(GetProcessHeap(), 0, sizeof(MetadataItem));
-    if (FAILED(hr))
+    if (!result)
     {
         HeapFree(GetProcessHeap(), 0, data);
         return E_OUTOFMEMORY;
-- 
1.7.8.3




More information about the wine-patches mailing list