winealsa: Fix AudioCaptureClient Get/ReleaseBuffer protocol. (try 2)

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Mon Jan 16 03:35:21 CST 2012


Hi,

You'll find my capture tests in testbot job #16332
http://testbot.winehq.org/JobDetails.pl?Key=16332

The surprising news is that (in shared mode), GetBuffer
never returns more than a period worth of data.
GetCurrentPadding can return much larger values.

With that patch in place, winealsa produces almost the
same test results on my mmdevapi capture tests as a w7 machine
-- modulo the few todo_wine.

Try2 fixes the incorrect call to GetPosition.  Maybe it's not a
good idea to remove the call entirely, because GetPosition
has the benefit of logging all ALSA parameters -- but it not
called unconditionally.

I've ran my capture&render tests in a loop with dmix and
results were stable over hundreds of iterations.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-winealsa-Fix-AudioCaptureClient-Get-ReleaseBuffer-p.patch
Type: application/octet-stream
Size: 4634 bytes
Desc: 0001-winealsa-Fix-AudioCaptureClient-Get-ReleaseBuffer-p.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20120116/246f69a2/attachment.obj>


More information about the wine-patches mailing list