msi: Avoid dead code in parse_prop (Coverity)

Frédéric Delanoy frederic.delanoy at gmail.com
Tue Jan 24 12:04:03 CST 2012


count != 0 when arriving at line 224, so the goto is never executed

One can only get to line 224 from state_token or state_quote, which already quit the function when
reading a space and count == 0

CID 1465
---
 dlls/msi/action.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 59e7b6d..665ca63 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -222,7 +222,6 @@ static int parse_prop( const WCHAR *str, WCHAR *value, int *quotes )
             switch (*p)
             {
             case ' ':
-                if (!count) goto done;
                 in_quotes = 1;
                 ignore = 1;
                 len++;
-- 
1.7.8.3




More information about the wine-patches mailing list