[2/7] msxml3: Fix node interface leak after nextNode()

Nikolay Sivov nsivov at codeweavers.com
Mon Jul 2 02:11:51 CDT 2012


Fix node interface leak after nextNode()
-------------- next part --------------
>From 222e49aae41fd688c028cbf826aa0a0d30fa7f7c Mon Sep 17 00:00:00 2001
From: Nikolay Sivov <nsivov at codeweavers.com>
Date: Sat, 30 Jun 2012 17:48:44 +0400
Subject: [PATCH 2/8] Fix node interface leak after nextNode()

---
 dlls/msxml3/selection.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/dlls/msxml3/selection.c b/dlls/msxml3/selection.c
index 55873bb..3cbf4e9 100644
--- a/dlls/msxml3/selection.c
+++ b/dlls/msxml3/selection.c
@@ -513,7 +513,11 @@ static HRESULT WINAPI enumvariant_Next(
 
     /* we need to advance one step more for some reason */
     if (ret_count)
+    {
+        node = NULL;
         IXMLDOMSelection_nextNode(This->selection, &node);
+        if (node) IXMLDOMNode_Release(node);
+    }
 
     return celt == 0 ? S_OK : S_FALSE;
 }
-- 
1.5.6.5




More information about the wine-patches mailing list