[PATCH] mshtml: remove superflous check (Coverity)

Marcus Meissner marcus at jet.franken.de
Wed Jul 18 13:27:03 CDT 2012


remove a superflous null ptr check (is dererenced earlier already)

CID709731

Ciao, Marcus
---
 dlls/mshtml/htmlwindow.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c
index 00e8b4d..3ade07e 100644
--- a/dlls/mshtml/htmlwindow.c
+++ b/dlls/mshtml/htmlwindow.c
@@ -2772,7 +2772,7 @@ HRESULT update_window_doc(HTMLInnerWindow *window)
     outer_window->base.inner_window = window;
     outer_window->pending_window = NULL;
 
-    if(outer_window->doc_obj && (outer_window->doc_obj->basedoc.window == outer_window || !outer_window->doc_obj->basedoc.window)) {
+    if(outer_window->doc_obj->basedoc.window == outer_window || !outer_window->doc_obj->basedoc.window) {
         if(outer_window->doc_obj->basedoc.doc_node)
             htmldoc_release(&outer_window->doc_obj->basedoc.doc_node->basedoc);
         outer_window->doc_obj->basedoc.doc_node = window->doc;
-- 
1.7.3.4




More information about the wine-patches mailing list