gdiplus: Comment out a test that crashes some gdiplus implementations.

Dmitry Timoshkov dmitry at baikal.ru
Thu Jun 28 03:52:24 CDT 2012


While running image.c tests under all available testbot VMs I noticed
that some of them crash https://testbot.winehq.org/JobDetails.pl?Key=19628
in this test:
stat = GdipBitmapSetPixel(bitmap, 1, -1, 0);
With this patch applied everything passes without exceptions:
https://testbot.winehq.org/JobDetails.pl?Key=19635
---
 dlls/gdiplus/tests/image.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c
index 9c60ad8..0cd29a9 100644
--- a/dlls/gdiplus/tests/image.c
+++ b/dlls/gdiplus/tests/image.c
@@ -1788,10 +1788,13 @@ static void test_getsetpixel(void)
        broken(stat == Ok), /* Older gdiplus */
        "Expected InvalidParameter, got %.8x\n", stat);
 
+if (0) /* crashes some gdiplus implementations */
+{
     stat = GdipBitmapSetPixel(bitmap, 1, -1, 0);
     ok(stat == InvalidParameter ||
        broken(stat == Ok), /* Older gdiplus */
        "Expected InvalidParameter, got %.8x\n", stat);
+}
 
     stat = GdipBitmapGetPixel(bitmap, 2, 1, &color);
     expect(InvalidParameter, stat);
-- 
1.7.11.1




More information about the wine-patches mailing list