[PATCH 1/5] d3d8: Don't return a pointer to the implementation in IDirect3DSurface8Impl_QueryInterface().
Henri Verbeet
hverbeet at codeweavers.com
Sun Mar 25 13:56:27 CDT 2012
---
dlls/d3d8/surface.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/dlls/d3d8/surface.c b/dlls/d3d8/surface.c
index 87c072a..fc212ea 100644
--- a/dlls/d3d8/surface.c
+++ b/dlls/d3d8/surface.c
@@ -33,19 +33,19 @@ static inline IDirect3DSurface8Impl *impl_from_IDirect3DSurface8(IDirect3DSurfac
static HRESULT WINAPI IDirect3DSurface8Impl_QueryInterface(IDirect3DSurface8 *iface, REFIID riid,
void **ppobj)
{
- IDirect3DSurface8Impl *This = impl_from_IDirect3DSurface8(iface);
-
TRACE("iface %p, riid %s, object %p.\n", iface, debugstr_guid(riid), ppobj);
- if (IsEqualGUID(riid, &IID_IUnknown)
- || IsEqualGUID(riid, &IID_IDirect3DResource8)
- || IsEqualGUID(riid, &IID_IDirect3DSurface8)) {
+ if (IsEqualGUID(riid, &IID_IDirect3DSurface8)
+ || IsEqualGUID(riid, &IID_IDirect3DResource8)
+ || IsEqualGUID(riid, &IID_IUnknown))
+ {
IUnknown_AddRef(iface);
- *ppobj = This;
+ *ppobj = iface;
return S_OK;
}
- WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj);
+ WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(riid));
+
*ppobj = NULL;
return E_NOINTERFACE;
}
--
1.7.3.4
More information about the wine-patches
mailing list