[PATCH] shell32: check return value of SHGetSpecialFolderPathW (Coverity)

Marcus Meissner marcus at jet.franken.de
Wed Oct 3 08:51:15 CDT 2012


Hi,

everything has checks, but this call. CID 728372

Ciao, Marcus
---
 dlls/shell32/shfldr_desktop.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/shell32/shfldr_desktop.c b/dlls/shell32/shfldr_desktop.c
index 6d52fd0..c22335a 100644
--- a/dlls/shell32/shfldr_desktop.c
+++ b/dlls/shell32/shfldr_desktop.c
@@ -332,7 +332,7 @@ static BOOL CreateDesktopEnumList(IEnumIDListImpl *list, DWORD dwFlags)
     }
 
     /* enumerate the elements in %windir%\desktop */
-    SHGetSpecialFolderPathW(0, szPath, CSIDL_DESKTOPDIRECTORY, FALSE);
+    ret = ret && SHGetSpecialFolderPathW(0, szPath, CSIDL_DESKTOPDIRECTORY, FALSE);
     ret = ret && CreateFolderEnumList(list, szPath, dwFlags);
 
     return ret;
-- 
1.7.3.4




More information about the wine-patches mailing list