[PATCH 1/3] hhctrl.ocx: Fix removing a window from the help list when window creation fails (try 2).

Erich E. Hoover ehoover at mymail.mines.edu
Wed Oct 3 10:31:40 CDT 2012


If a cleanup occurs because HTML Help window creation fails then
list_remove() causes a crash, since the window was never added to the
window list.  The attached patch fixes this issue, allowing safe
reloading of HTML Help files (needed for part 2).  Jacek Caban pointed
out that checking the list to see if it's ok to remove the entry isn't
very elegant, so this version moves the addition of the list entry so
that it's always safe to remove the HHInfo structure from the list.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-hhctrl.ocx-Fix-removing-a-window-from-the-help-list-.patch
Type: application/octet-stream
Size: 1143 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20121003/7ec649a5/attachment.obj>


More information about the wine-patches mailing list