view: Buffer size of GetFileTitleW is in characters, not bytes (coverity)

André Hentschel nerv at dawncrow.de
Mon Oct 22 12:31:36 CDT 2012


CID 713259 & 713260
---
 programs/view/view.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/programs/view/view.c b/programs/view/view.c
index d32a10b..9e60824 100644
--- a/programs/view/view.c
+++ b/programs/view/view.c
@@ -260,7 +260,7 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT uMessage, WPARAM wparam, LPARAM
               if (FileOpen(hwnd, filename, sizeof(filename)/sizeof(WCHAR)))
               {
                   szFileTitle[0] = 0;
-                  GetFileTitleW(filename, szFileTitle, sizeof(szFileTitle));
+                  GetFileTitleW(filename, szFileTitle, sizeof(szFileTitle)/sizeof(WCHAR));
                   DoOpenFile(filename);
                   UpdateWindowCaption();
               }
@@ -387,7 +387,7 @@ static void HandleCommandLine(LPWSTR cmdline)
             cmdline[lstrlenW(cmdline) - 1] = 0;
         }
         szFileTitle[0] = 0;
-        GetFileTitleW(cmdline, szFileTitle, sizeof(szFileTitle));
+        GetFileTitleW(cmdline, szFileTitle, sizeof(szFileTitle)/sizeof(WCHAR));
         DoOpenFile(cmdline);
         UpdateWindowCaption();
     }
-- 
1.7.4.1


-- 

Best Regards, André Hentschel


More information about the wine-patches mailing list