[PATCH 3/4] mciseq: Fix reading MCI_INFO_NAME and COPYRIGHT from MIDI file. [was 16/25]

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Thu Oct 25 02:43:16 CDT 2012


Hi,

-           /* position after meta data header */
-           mmioSeek(wmm->hFile, mmt->dwIndex + HIWORD(mmt->dwEventData), SEEK_SET);
Code that never worked right...
This is the kind of thing that you find out when you actually write tests.

+                   } /* last name or name from last track wins */
The tests in patch 17 do not include a MIDI file with multiple
tracks and names.  You'll have to trust me that I tested that
behaviour anyway (or you'll need a w9x machine because that
functionality is unsupported since the NT mciseq rewrite).

Regards,
        Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-mciseq-Fix-reading-MCI_INFO_NAME-and-COPYRIGHT-from.patch
Type: application/octet-stream
Size: 2957 bytes
Desc: 0003-mciseq-Fix-reading-MCI_INFO_NAME-and-COPYRIGHT-from.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20121025/7300af88/attachment.obj>


More information about the wine-patches mailing list