cmd: Avoid handle leaks (coverity)

Frédéric Delanoy frederic.delanoy at gmail.com
Tue Oct 30 11:31:28 CDT 2012


CIDs 739900 & 739901
---
 programs/cmd/builtins.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c
index e567bb6..b3fd422 100644
--- a/programs/cmd/builtins.c
+++ b/programs/cmd/builtins.c
@@ -394,6 +394,7 @@ static BOOL WCMD_AppendEOF(WCHAR *filename)
       SetFilePointer (h, 0, NULL, FILE_END);
       if (!WriteFile(h, &eof, 1, NULL, NULL)) {
         WINE_ERR("Failed to append EOF to %s (%d)\n", wine_dbgstr_w(filename), GetLastError());
+        CloseHandle(h);
         return FALSE;
       }
       CloseHandle(h);
@@ -430,6 +431,7 @@ static BOOL WCMD_ManualCopy(WCHAR *srcname, WCHAR *dstname, BOOL ascii, BOOL app
                       append?OPEN_EXISTING:CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
     if (out == NULL) {
       WINE_ERR("Failed to open %s (%d)\n", wine_dbgstr_w(dstname), GetLastError());
+      CloseHandle(in);
       return FALSE;
     }
 
-- 
1.8.0




More information about the wine-patches mailing list