[PATCH] shell32: use characters not bytes in 1 place (Coverity)

Marcus Meissner meissner at suse.de
Sun Sep 2 08:12:34 CDT 2012


Hi,

CID 718725

The shlexec.c has some more functions pass around bytecount instead
of charactercount...  confusing a bit.

Ciao, Marcus
---
 dlls/shell32/shlexec.c |    2 +-
 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)

diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c
index e351d86..a1599e4 100644
--- a/dlls/shell32/shlexec.c
+++ b/dlls/shell32/shlexec.c
@@ -1430,7 +1430,7 @@ static BOOL SHELL_translate_idlist( LPSHELLEXECUTEINFOW sei, LPWSTR wszParameter
     BOOL appKnownSingular = FALSE;
 
     /* last chance to translate IDList: now also allow CLSID paths */
-    if (SUCCEEDED(SHELL_GetPathFromIDListForExecuteW(sei->lpIDList, buffer, sizeof(buffer)))) {
+    if (SUCCEEDED(SHELL_GetPathFromIDListForExecuteW(sei->lpIDList, buffer, sizeof(buffer)/sizeof(WCHAR)))) {
         if (buffer[0]==':' && buffer[1]==':') {
             /* open shell folder for the specified class GUID */
             if (strlenW(buffer) + 1 > parametersLen)
-- 
1.7.10.4




More information about the wine-patches mailing list