[PATCH] gdi32: fixed passed buffer size

Marcus Meissner marcus at jet.franken.de
Fri Sep 7 13:34:33 CDT 2012


Hi,

my overflow check macros spotted this buffer size vs sizeof
issue.

sizeof(bufW) would be twice as large as bufA.

Ciao, Marcus
---
 dlls/gdi32/tests/font.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c
index 26d88ae..3f7af21 100644
--- a/dlls/gdi32/tests/font.c
+++ b/dlls/gdi32/tests/font.c
@@ -4037,7 +4037,7 @@ static void test_fullname(void)
         bufA[0] = 0;
         ret = get_ttf_nametable_entry(hdc, TT_NAME_ID_FULL_NAME, bufW, sizeof(bufW), TT_MS_LANGID_ENGLISH_UNITED_STATES);
         ok(ret, "face full name could not be read\n");
-        WideCharToMultiByte(CP_ACP, 0, bufW, -1, bufA, sizeof(bufW), NULL, FALSE);
+        WideCharToMultiByte(CP_ACP, 0, bufW, -1, bufA, sizeof(bufA), NULL, FALSE);
         ok(!lstrcmpA(bufA, TestName[i]), "font full names don't match: %s != %s\n", TestName[i], bufA);
         SelectObject(hdc, of);
         DeleteObject(hfont);
-- 
1.7.3.4




More information about the wine-patches mailing list