[PATCH 3/5] gdi32: Fixed localized font style name.

Qian Hong fracting at gmail.com
Mon Sep 10 12:05:57 CDT 2012


Hello,

This test show us that font style name is localized if exist:
https://testbot.winehq.org/JobDetails.pl?Key=21497

For example:
--- snip ---
font.c:4085: Checking font Webdings:
FamilyName: Webdings; FaceName: Webdings; StyleName: Standaard
font.c:4111: no localized FONT_FAMILY found.
font.c:4125: no localized FULL_NAME found.
--- snip ---

Unfortunately, there are very few real world fonts which have localized style name. The only test cases I found are Webdings, Wingdings and some other symbol fonts. Unfortunately again, we have another symbol font bug which I'd like to demonstrate in [PATCH 4/5] and fix in [PATCH 5/5]. To keep the patches atomized and clean I submit this patch before [PATCH 4/5], without adding any "todo_wine", and without adding new testing font. In fact the new test case in [PATCH 4/5] will cover both the localized font style name behavior (without todo_wine because it should have been fixed in [PATCH 3/5]) and the symbol font bug (with todo_wine because it need to be fixed in [PATCH 4/5].

Please let me know if this is acceptable, if not I'm glad to try a better way.

Thanks a lot!

---
 dlls/gdi32/freetype.c   |   26 ++++++++++++++++++++------
 dlls/gdi32/tests/font.c |    7 ++++++-
 2 files changed, 26 insertions(+), 7 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-gdi32-Fixed-localized-font-style-name.txt
Type: text/x-patch
Size: 3291 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20120911/50378a68/attachment.bin>


More information about the wine-patches mailing list