[PATCH] rpcrt4: free url in error paths (Coverity)
Marcus Meissner
marcus at jet.franken.de
Sat Aug 31 03:56:52 CDT 2013
713689 Resource leak
2 error paths were missing to free url
Ciao, Marcus
---
dlls/rpcrt4/rpc_transport.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c
index 8932f10..c004f66 100644
--- a/dlls/rpcrt4/rpc_transport.c
+++ b/dlls/rpcrt4/rpc_transport.c
@@ -2533,12 +2533,16 @@ static RPC_STATUS rpcrt4_ncacn_http_open(RpcConnection* Connection)
return RPC_S_SERVER_UNAVAILABLE;
}
status = insert_authorization_header(httpc->in_request, httpc->common.QOS);
- if (status != RPC_S_OK)
+ if (status != RPC_S_OK) {
+ HeapFree(GetProcessHeap(), 0, url);
return status;
+ }
status = insert_cookie_header(httpc->in_request, Connection->CookieAuth);
- if (status != RPC_S_OK)
+ if (status != RPC_S_OK) {
+ HeapFree(GetProcessHeap(), 0, url);
return status;
+ }
httpc->out_request = HttpOpenRequestW(httpc->session, wszVerbOut, url, NULL, NULL, wszAcceptTypes,
flags, (DWORD_PTR)httpc->async_data);
--
1.7.10.4
More information about the wine-patches
mailing list