testbot/TestAgent: Fix create_ip_socket().

Francois Gouget fgouget at codeweavers.com
Tue Dec 17 04:01:24 CST 2013


It's not supposed to mask exceptions as that prevents the detection of connection timeouts.
---
 testbot/lib/WineTestBot/TestAgent.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm
index f542991..dfc86e3 100644
--- a/testbot/lib/WineTestBot/TestAgent.pm
+++ b/testbot/lib/WineTestBot/TestAgent.pm
@@ -790,9 +790,7 @@ sub _SendFile($$$)
 
 sub create_ip_socket(@)
 {
-  my $socket;
-  eval { $socket = IO::Socket::IP->new(@_); };
-  return $socket;
+  return IO::Socket::IP->new(@_);
 }
 
 sub create_inet_socket(@)
-- 
1.8.5.1




More information about the wine-patches mailing list