comctl32/tests: drop broken test

Daniel Jelinski djelinski1 at gmail.com
Wed Feb 6 14:30:37 CST 2013


-------------- next part --------------
From 0bc5ec80a17e7fc80e06858816731c85ab6fb637 Mon Sep 17 00:00:00 2001
From: Daniel Jelinski <djelinski1 at gmail.com>
Date: Wed, 6 Feb 2013 21:18:35 +0100
Subject: [PATCH] comctl32/tests: drop broken test

Wondering why two of my patches got accepted, but the third one did not,
I checked the one that did not get in (94131) and noticed that I split
the tests incorrectly - two of the tests introduced by 94129 pass in wine,
but will inevitably fail in windows. Sorry for that.

This patch drops the broken test. Patch 94131 fixes the test, and also
fixes listview so that all tests may succeed, so I'd prefer if 94131
got accepted and this one rejected.
---
 dlls/comctl32/tests/listview.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c
index c46fe42..c80fe1b 100644
--- a/dlls/comctl32/tests/listview.c
+++ b/dlls/comctl32/tests/listview.c
@@ -4639,14 +4639,6 @@ static void test_getitemspacing(void)
     expect(100, LOWORD(ret));
     expect(100, HIWORD(ret));
 
-    /* now change image list - icon spacing should be unaffected */
-    SendMessage(hwnd, LVM_SETIMAGELIST, LVSIL_NORMAL, (LPARAM)himl40);
-
-    ret = SendMessage(hwnd, LVM_GETITEMSPACING, FALSE, 0);
-    /* spacing + icon size returned */
-    expect(cx + 40, LOWORD(ret));
-    expect(cy + 40, HIWORD(ret));
-
     SendMessage(hwnd, LVM_SETIMAGELIST, LVSIL_NORMAL, 0);
     ImageList_Destroy(himl80);
     DestroyWindow(hwnd);
-- 
1.7.5.4


More information about the wine-patches mailing list