make_xftmpl: Explicitly use signed char when appropriate

André Hentschel nerv at dawncrow.de
Mon Feb 11 08:08:03 CST 2013


For platforms where char is expected to be unsigned (e.g. it fixes a warning on ARM)

---
 tools/make_xftmpl.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/make_xftmpl.c b/tools/make_xftmpl.c
index 85b373f..7f890ae 100644
--- a/tools/make_xftmpl.c
+++ b/tools/make_xftmpl.c
@@ -103,7 +103,7 @@ static const struct keyword reserved_words[] = {
 
 static char *program_name;
 
-static inline BOOL read_byte(struct parser *parser, char *byte)
+static inline BOOL read_byte(struct parser *parser, signed char *byte)
 {
     int c = fgetc(parser->infile);
     *byte = c;
@@ -216,7 +216,7 @@ static BOOL parse_guid(struct parser *parser)
 
 static BOOL parse_name(struct parser *parser)
 {
-    char c;
+    signed char c;
     int len = 0;
     char name[512];
 
@@ -241,7 +241,7 @@ static BOOL parse_name(struct parser *parser)
 static BOOL parse_number(struct parser *parser)
 {
     int len = 0;
-    char c;
+    signed char c;
     char buffer[512];
     BOOL dot = FALSE;
     BOOL ret;
@@ -286,7 +286,7 @@ static BOOL parse_number(struct parser *parser)
 
 static BOOL parse_token(struct parser *parser)
 {
-    char c;
+    signed char c;
 
     if (!read_byte(parser, &c))
         return FALSE;
-- 
1.8.0


-- 

Best Regards, André Hentschel


More information about the wine-patches mailing list