comctl32/listview: fix selection in ownerdata listview

Daniel Jelinski djelinski1 at gmail.com
Wed Feb 20 16:19:33 CST 2013


-------------- next part --------------
From f57a993fed6a3ccdde58fa9f5666187c0255a599 Mon Sep 17 00:00:00 2001
From: Daniel Jelinski <djelinski1 at gmail.com>
Date: Wed, 20 Feb 2013 23:01:52 +0100
Subject: [PATCH 2/2] comctl32/listview: fix selection in ownerdata listview

wine should actually send LVN_ODSTATCHANGED, as the fixme says.
As long as it does not, LVN_ITEMCHANGED messages also work.
This patch brings back LVN_ITEMCHANGED notifications.
Fixes Shift+click selection in owner data listviews (bug 19350)
---
 dlls/comctl32/listview.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index 83bdf56..0158e8f 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -3627,7 +3627,7 @@ static void LISTVIEW_SetGroupSelection(LISTVIEW_INFO *infoPtr, INT nItem)
     /* disable per item notifications on LVS_OWNERDATA style
        FIXME: single LVN_ODSTATECHANGED should be used */
     bOldChange = infoPtr->bDoChangeNotify;
-    if (infoPtr->dwStyle & LVS_OWNERDATA) infoPtr->bDoChangeNotify = FALSE;
+    /*if (infoPtr->dwStyle & LVS_OWNERDATA) infoPtr->bDoChangeNotify = FALSE;*/
 
     LISTVIEW_DeselectAllSkipItems(infoPtr, selection);
 
-- 
1.7.5.4


More information about the wine-patches mailing list