quartz: Avoid signed-unsigned integer comparisons

Andrew Talbot andrew.talbot at talbotville.com
Sat Feb 23 16:49:16 CST 2013


Changelog:
    quartz: Avoid signed-unsigned integer comparisons.

diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c
index 847b460..de83a93 100644
--- a/dlls/quartz/vmr9.c
+++ b/dlls/quartz/vmr9.c
@@ -1495,7 +1495,7 @@ static HRESULT WINAPI VMR9SurfaceAllocatorNotify_ChangeD3DDevice(IVMRSurfaceAllo
 static HRESULT WINAPI VMR9SurfaceAllocatorNotify_AllocateSurfaceHelper(IVMRSurfaceAllocatorNotify9 *iface, VMR9AllocationInfo *allocinfo, DWORD *numbuffers, IDirect3DSurface9 **surface)
 {
     VMR9Impl *This = impl_from_IVMRSurfaceAllocatorNotify9(iface);
-    INT i;
+    DWORD i;
     HRESULT hr = S_OK;
 
     FIXME("(%p/%p)->(%p, %p => %u, %p) semi-stub\n", iface, This, allocinfo, numbuffers, (numbuffers ? *numbuffers : 0), surface);
@@ -1555,9 +1555,9 @@ static HRESULT WINAPI VMR9SurfaceAllocatorNotify_AllocateSurfaceHelper(IVMRSurfa
     else
     {
         ERR("Allocation failed\n");
-        for (--i; i >= 0; --i)
+        for ( ; i > 0; --i)
         {
-            IDirect3DSurface9_Release(surface[i]);
+            IDirect3DSurface9_Release(surface[i - 1]);
         }
         *numbuffers = 0;
     }
@@ -1691,7 +1691,7 @@ static ULONG WINAPI VMR9_ImagePresenter_Release(IVMRImagePresenter9 *iface)
 
     if (!refCount)
     {
-        int i;
+        DWORD i;
         TRACE("Destroying\n");
         CloseHandle(This->ack);
         IDirect3D9_Release(This->d3d9_ptr);
@@ -2091,7 +2091,7 @@ static HRESULT VMR9_SurfaceAllocator_UpdateDeviceReset(VMR9DefaultAllocatorPrese
 {
     struct VERTEX t_vert[4];
     UINT width, height;
-    INT i;
+    unsigned int i;
     void *bits = NULL;
     D3DPRESENT_PARAMETERS d3dpp;
     HRESULT hr;




More information about the wine-patches mailing list