[01/12] testbot/TestAgent: 'nc -q0' seems to be the default but make it explicit just in case.

Francois Gouget fgouget at codeweavers.com
Mon Feb 25 10:02:26 CST 2013


When the client disconnects it shuts down the ssh connection which leads 
to netcat's stdin. When that happens netcat gets an EOF and we then want 
it to exit right away rather than hang around and potentially prevent 
us from reconnecting to the testagentd server.

 testbot/lib/WineTestBot/TestAgent.pm |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm
index f06bd71..1f52818 100644
--- a/testbot/lib/WineTestBot/TestAgent.pm
+++ b/testbot/lib/WineTestBot/TestAgent.pm
@@ -851,7 +851,7 @@ sub _Connect($)
     # Use netcat to forward the connection from the SSH server to the TestAgent
     # server. Note that we won't know about netcat errors at this point.
-    if (!$self->{fd}->exec("nc '$self->{agenthost}' '$self->{agentport}'"))
+    if (!$self->{fd}->exec("nc -q0 '$self->{agenthost}' '$self->{agentport}'"))
       $self->_SetError($FATAL, "Unable to start netcat: " . $self->_ssherror());
       return undef;

More information about the wine-patches mailing list