[PATCH 2/3] mmsystem: Do not rewrite input parameters.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Wed Feb 27 07:35:43 CST 2013


MMTIME is output only
dwUser is what the name says, not Wine's business
dwLoops is not modified by Wine, etc.

another time I'll talk about dwOffset in wine-devel

@@ -1288,24 +1274,11 @@ UINT16 WINAPI waveOutPrepareHeader16(HWAVEOUT16 hWaveOut,      /* [in] */
-    if ((result = MMSYSTDRV_Message(HWAVEOUT_32(hWaveOut), WODM_PREPARE, lpsegWaveOutHdr,
-                                    uSize)) != MMSYSERR_NOTSUPPORTED)
There's no such code in Wine's winmm/waveform.c

It may be something left from the time when the individual drivers were answering WODM_PREPARE
and I remember reading that lazy drivers are allowed to answer UNSUPPORTED and have winmm perform default
handling and return NOERROR.  OTOH, isn't this the case for the ACM drivers only?

 Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-mmsystem-Do-not-rewrite-input-parameters.patch
Type: application/octet-stream
Size: 5749 bytes
Desc: 0002-mmsystem-Do-not-rewrite-input-parameters.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20130227/bdfeec51/attachment.obj>

More information about the wine-patches mailing list