testbot/testagentd: Better handle unknown RPCs.

Francois Gouget fgouget at codeweavers.com
Mon Jan 21 21:02:04 CST 2013


Only return an error if the unknown RPC parameters have successfully been parsed. If not the connection state is broken anyway.
---
 testbot/src/testagentd/testagentd.c |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/testbot/src/testagentd/testagentd.c b/testbot/src/testagentd/testagentd.c
index 13d16e4..3de9a3c 100644
--- a/testbot/src/testagentd/testagentd.c
+++ b/testbot/src/testagentd/testagentd.c
@@ -855,11 +855,12 @@ static void do_unknown(SOCKET client, uint32_t id)
 {
     uint32_t argc;
 
-    if (recv_list_size(client, &argc))
-        skip_entries(client, argc);
-
-    set_status(ST_ERROR, "unknown RPC %s", rpc_name(id));
-    send_error(client);
+    if (recv_list_size(client, &argc) &&
+        skip_entries(client, argc))
+    {
+        set_status(ST_ERROR, "unknown RPC %s", rpc_name(id));
+        send_error(client);
+    }
 }
 
 static void process_rpc(SOCKET client)
-- 
1.7.10.4




More information about the wine-patches mailing list