[PATCH] cmd: null terminate answer string (Coverity)

Marcus Meissner marcus at jet.franken.de
Wed Jul 10 01:26:14 CDT 2013


713919 String not null terminated
---
 programs/cmd/builtins.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c
index aa1e7d4..64e12a0 100644
--- a/programs/cmd/builtins.c
+++ b/programs/cmd/builtins.c
@@ -400,6 +400,7 @@ void WCMD_choice (const WCHAR * args) {
     while (TRUE) {
 
         /* FIXME: Add support for option /T */
+        answer[1] = 0; /* terminate single character string */
         WCMD_ReadFile(GetStdHandle(STD_INPUT_HANDLE), answer, 1, &count);
 
         if (!opt_s)
-- 
1.7.10.4




More information about the wine-patches mailing list