[2/2] ole32: Use WARN instead of ERR/FIXME if an object doesn't expose some interface.

Dmitry Timoshkov dmitry at baikal.ru
Thu Jun 13 22:03:03 CDT 2013


An object can't be expected to support all the interfaces it's been queried for.
---
 dlls/ole32/marshal.c     | 8 ++++----
 dlls/ole32/stubmanager.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/ole32/marshal.c b/dlls/ole32/marshal.c
index 0de4660..6ec5f4c 100644
--- a/dlls/ole32/marshal.c
+++ b/dlls/ole32/marshal.c
@@ -136,11 +136,11 @@ HRESULT marshal_object(APARTMENT *apt, STDOBJREF *stdobjref, REFIID riid, IUnkno
     hr = IUnknown_QueryInterface(object, riid, (void **)&iobject);
     if (hr != S_OK)
     {
-        ERR("object doesn't expose interface %s, failing with error 0x%08x\n",
+        WARN("object doesn't expose interface %s, failing with error 0x%08x\n",
             debugstr_guid(riid), hr);
         return E_NOINTERFACE;
     }
-  
+
     /* IUnknown doesn't require a stub buffer, because it never goes out on
      * the wire */
     if (!IsEqualIID(riid, &IID_IUnknown))
@@ -154,7 +154,7 @@ HRESULT marshal_object(APARTMENT *apt, STDOBJREF *stdobjref, REFIID riid, IUnkno
             IUnknown_Release(iobject);
             return hr;
         }
-    
+
         hr = IPSFactoryBuffer_CreateStub(psfb, riid, iobject, &stub);
         IPSFactoryBuffer_Release(psfb);
         if (hr != S_OK)
@@ -323,7 +323,7 @@ static HRESULT WINAPI ClientIdentity_QueryMultipleInterfaces(IMultiQI *iface, UL
                                                nonlocal_mqis, iids, &qiresults);
             IRemUnknown_Release(remunk);
             if (FAILED(hr))
-                ERR("IRemUnknown_RemQueryInterface failed with error 0x%08x\n", hr);
+                WARN("IRemUnknown_RemQueryInterface failed with error 0x%08x\n", hr);
         }
 
         /* IRemUnknown_RemQueryInterface can return S_FALSE if only some of
diff --git a/dlls/ole32/stubmanager.c b/dlls/ole32/stubmanager.c
index 822b299..a9c8424 100644
--- a/dlls/ole32/stubmanager.c
+++ b/dlls/ole32/stubmanager.c
@@ -633,7 +633,7 @@ static HRESULT WINAPI RemUnknown_QueryInterface(IRemUnknown *iface, REFIID riid,
         return S_OK;
     }
 
-    FIXME("No interface for iid %s\n", debugstr_guid(riid));
+    WARN("No interface for iid %s\n", debugstr_guid(riid));
 
     *ppv = NULL;
     return E_NOINTERFACE;
-- 
1.8.3.1




More information about the wine-patches mailing list