queue.c : Properly implementation of the SetupDefaultQueueCallback functions

[Bartosz Kosiorek]

Hi.

By using following patch you could silent FIXME warnings.

It's implements handling of SPFILENOTIFY_TARGETNEWER.
SPFILENOTIFY_TARGETEXISTS and SPFILENOTIFY_LANGMISMATCH events.

Best Regards
Bartosz
-------------- next part --------------
From 3c96127144efcd0c8974c1515025de794a2430bc Mon Sep 17 00:00:00 2001
From: Bartosz Kosiorek <gang65 at poczta.onet.pl>
Date: Mon, 24 Jun 2013 21:30:49 +0200
Subject: =?UTF-8?q?Silent=20FIXME=20warnings,=20by=20properly=20implementa?=
 =?UTF-8?q?tion=20of=20the=0ASetupDefaultQueueCallbackA=20and=20SetupDefau?=
 =?UTF-8?q?ltQueueCallbackW=0Afunctions.?=

---
 dlls/setupapi/queue.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/dlls/setupapi/queue.c b/dlls/setupapi/queue.c
index 1855e99..ad5ece8 100644
--- a/dlls/setupapi/queue.c
+++ b/dlls/setupapi/queue.c
@@ -1557,6 +1557,18 @@ UINT WINAPI SetupDefaultQueueCallbackA( PVOID context, UINT notification,
     case SPFILENOTIFY_NEEDMEDIA:
         TRACE( "need media\n" );
         return FILEOP_SKIP;
+    case SPFILENOTIFY_TARGETNEWER:
+        TRACE( "Newer version of %s already exists in directory\n", debugstr_w(paths->Target) );
+        //Skip the current copy operation
+        return 0;
+    case SPFILENOTIFY_TARGETEXISTS:
+        TRACE( "Target file %s already exists in directory\n", debugstr_w(paths->Target) );
+        //Skip the current copy operation
+        return 0;
+    case SPFILENOTIFY_LANGMISMATCH:
+        TRACE( "Wrong language file to be copied %s\n", debugstr_w(paths->Target) );
+        //Do not overwrite the existing file.
+        return 0;
     default:
         FIXME( "notification %d params %lx,%lx\n", notification, param1, param2 );
         break;
@@ -1622,6 +1634,18 @@ UINT WINAPI SetupDefaultQueueCallbackW( PVOID context, UINT notification,
     case SPFILENOTIFY_NEEDMEDIA:
         TRACE( "need media\n" );
         return FILEOP_SKIP;
+    case SPFILENOTIFY_TARGETNEWER:
+        TRACE( "Newer version of %s already exists in directory\n", debugstr_w(paths->Target) );
+        //Skip the current copy operation
+        return 0;
+    case SPFILENOTIFY_TARGETEXISTS:
+        TRACE( "Target file %s already exists in directory\n", debugstr_w(paths->Target) );
+        //Skip the current copy operation
+        return 0;
+    case SPFILENOTIFY_LANGMISMATCH:
+        TRACE( "Wrong language file to be copied %s\n", debugstr_w(paths->Target) );
+        //Do not overwrite the existing file.
+        return 0;
     default:
         FIXME( "notification %d params %lx,%lx\n", notification, param1, param2 );
         break;
-- 
1.8.1.2