wininet: Avoid signed-unsigned integer comparisons

Andrew Talbot andrew.talbot at talbotville.com
Wed Mar 6 15:43:27 CST 2013


Changelog:
    wininet: Avoid signed-unsigned integer comparisons.

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
index 8fec2a4..c5508e8 100644
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -4313,7 +4313,7 @@ static WORD HTTP_ParseWeekday(LPCWSTR day)
                                      { 't','h','u','r','s','d','a','y',0 },
                                      { 'f','r','i','d','a','y',0 },
                                      { 's','a','t','u','r','d','a','y',0 }};
-    int i;
+    unsigned int i;
     for (i = 0; i < sizeof(days)/sizeof(*days); i++)
         if (!strcmpiW(day, days[i]))
             return i;
diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c
index 384516c..2f62abb 100644
--- a/dlls/wininet/internet.c
+++ b/dlls/wininet/internet.c
@@ -2836,7 +2836,7 @@ BOOL WINAPI InternetSetOptionW(HINTERNET hInternet, DWORD dwOption,
     case INTERNET_OPTION_PER_CONNECTION_OPTION: {
         INTERNET_PER_CONN_OPTION_LISTW *con = lpBuffer;
         LONG res;
-        int i;
+        unsigned int i;
         proxyinfo_t pi;
 
         INTERNET_LoadProxySettings(&pi);
@@ -2950,7 +2950,7 @@ BOOL WINAPI InternetSetOptionA(HINTERNET hInternet, DWORD dwOption,
                                    wbuffer, wlen );
         break;
     case INTERNET_OPTION_PER_CONNECTION_OPTION: {
-        int i;
+        DWORD i;
         INTERNET_PER_CONN_OPTION_LISTW *listW;
         INTERNET_PER_CONN_OPTION_LISTA *listA = lpBuffer;
         wlen = sizeof(INTERNET_PER_CONN_OPTION_LISTW);
@@ -3019,7 +3019,7 @@ BOOL WINAPI InternetSetOptionA(HINTERNET hInternet, DWORD dwOption,
         if (dwOption == INTERNET_OPTION_PER_CONNECTION_OPTION)
         {
             INTERNET_PER_CONN_OPTION_LISTW *list = wbuffer;
-            int i;
+            DWORD i;
             for (i = 0; i < list->dwOptionCount; ++i) {
                 INTERNET_PER_CONN_OPTIONW *opt = list->pOptions + i;
                 switch (opt->dwOption) {
diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c
index 3564282..c33f45a 100644
--- a/dlls/wininet/netconnection.c
+++ b/dlls/wininet/netconnection.c
@@ -477,7 +477,7 @@ static CRITICAL_SECTION init_ssl_cs = { &init_ssl_cs_debug, -1, 0, 0, 0, 0 };
 static DWORD init_openssl(void)
 {
 #ifdef SONAME_LIBCRYPTO
-    int i;
+    unsigned int i;
 
     if(OpenSSL_ssl_handle)
         return ERROR_SUCCESS;
@@ -730,7 +730,7 @@ void NETCON_unload(void)
     }
     if (ssl_locks)
     {
-        int i;
+        unsigned int i;
         for (i = 0; i < num_ssl_locks; i++)
         {
             ssl_locks[i].DebugInfo->Spare[0] = 0;
diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c
index 0c9a4e2..01311bfb 100644
--- a/dlls/wininet/urlcache.c
+++ b/dlls/wininet/urlcache.c
@@ -336,7 +336,7 @@ static DWORD URLCacheContainer_OpenIndex(URLCACHECONTAINER * pContainer, DWORD b
 		    WCHAR *pwchDir;
 		    WCHAR wszDirPath[MAX_PATH];
 		    FILETIME ft;
-		    int i, j;
+		    unsigned int i, j;
                     HASH_CACHEFILE_ENTRY *pHashEntry;
 
 		    /* First set some constants and defaults in the header */




More information about the wine-patches mailing list