[PATCH 3/4] wined3d: Correct an ERR/FIXME

Stefan Dösinger stefan at codeweavers.com
Tue May 21 06:18:20 CDT 2013


The code can get entered if the application does not set a palette. My
hacky testing shows that the system palette should be used in this case.
Considering the problems that some old P8 games (Age of Empires 2,
StarCraft, ...) have on Windows 7 as well as a semi-documented
workaround, it is quite possible that assigning a palette to the front
buffer sets the system palette and the code that writes to the screen
always uses the system palette.
---
 dlls/wined3d/surface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c
index cdd744c..bd7fbd7 100644
--- a/dlls/wined3d/surface.c
+++ b/dlls/wined3d/surface.c
@@ -4563,7 +4563,7 @@ void d3dfmt_p8_init_palette(const struct wined3d_surface *surface, BYTE table[25
 
     if (!pal)
     {
-        ERR("This code should never get entered for DirectDraw!, expect problems\n");
+        FIXME("No palette set.\n");
         if (index_in_alpha)
         {
             /* Guarantees that memory representation remains correct after sysmem<->texture transfers even if
-- 
1.8.1.5




More information about the wine-patches mailing list