[PATCH] oledb32: avoid leak in error path on safearray conversion (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat May 25 02:25:19 CDT 2013


CID 1025790
---
 dlls/oledb32/convert.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/oledb32/convert.c b/dlls/oledb32/convert.c
index 0961464..a2fd0cb 100644
--- a/dlls/oledb32/convert.c
+++ b/dlls/oledb32/convert.c
@@ -957,8 +957,10 @@ static HRESULT WINAPI convert_DataConvert(IDataConvert* iface,
             for(i =0; i < size; i++,p++)
             {
                 hr = SafeArrayPutElement(psa, &i, &p);
-                if(FAILED(hr))
+                if(FAILED(hr)) {
+                   SafeArrayDestroy (psa);
                    return hr;
+                }
             }
 
             V_VT(v) = VT_ARRAY|VT_UI1;
-- 
1.7.10.4




More information about the wine-patches mailing list