[PATCH] services: fix handle leak for service handles (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun May 26 08:31:51 CDT 2013


CID  739902 Resource leak

Need to call CloseServiceHandle to actually close it too.
---
 programs/services/tests/service.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/programs/services/tests/service.c b/programs/services/tests/service.c
index 99d28eb..a2cd0b5 100644
--- a/programs/services/tests/service.c
+++ b/programs/services/tests/service.c
@@ -328,6 +328,7 @@ static void test_service(void)
     ok(res, "StartService failed: %u\n", GetLastError());
     if(!res) {
         DeleteService(service_handle);
+        CloseServiceHandle(service_handle);
         return;
     }
     expect_event("RUNNING");
@@ -368,6 +369,7 @@ static inline void test_no_stop(void)
     ok(res, "StartService failed: %u\n", GetLastError());
     if(!res) {
         DeleteService(service_handle);
+        CloseServiceHandle(service_handle);
         return;
     }
     expect_event("RUNNING");
-- 
1.7.10.4




More information about the wine-patches mailing list