msvcrt: remove hack (resend)

Austin English austinenglish at gmail.com
Thu May 30 15:28:11 CDT 2013


This time, with the patch

This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b

but clang doesn't like it:
clang -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__
-D_MT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
-Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers
-Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith
-gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer  -g -O2  -o process.o
process.c
process.c:363:10: warning: explicitly assigning a variable of type
'int' to itself [-Wself-assign]
  action = action; /* Remove warning */
  ~~~~~~ ^ ~~~~~~
1 warning generated.

and no modern gcc/other compiler that I can find cares.

--
-Austin
-------------- next part --------------
diff --git a/dlls/msvcrt/process.c b/dlls/msvcrt/process.c
index b61eea1..4505b67 100644
--- a/dlls/msvcrt/process.c
+++ b/dlls/msvcrt/process.c
@@ -360,8 +360,6 @@ MSVCRT_intptr_t CDECL _cwait(int *status, MSVCRT_intptr_t pid, int action)
   HANDLE hPid = (HANDLE)pid;
   int doserrno;
 
-  action = action; /* Remove warning */
-
   if (!WaitForSingleObject(hPid, INFINITE))
   {
     if (status)


More information about the wine-patches mailing list