[PATCH 2/2] user32/tests: Skip a test to avoid wineserver desktop manager bug.
qhong at codeweavers.com
Sat Nov 9 03:52:58 CST 2013
There are three reasons to introduce this patch:
The original motivation of test_foregroundwindow() is to test
OpenInputDesktop() and SwitchDesktop(), especially for testing the
latter. However, according to recently discussion in wine-devel , it
is imposible to implement SwitchDesktop() in Wine correctly, so this
test doesn't make too much sense, especially after "user32: Implement
OpenInputDesktop."  has been committed.
Currently, this patch causes randomly failures on some Windows versions,
mostly like related to sleeping time, which can't be reproduced when run
the test standalonely . It is possible to fix the failures by
submitting a patch which increase sleeping time, but it doesn't make too
much sense according to point 1.
This patch discovered a wineserver bug: wineserver desktop manager
doesn't count thread as user, it just count process as user.
To fix this bug, we have to modify some wineserver code, but I haven't
found any real world app affects by this bug yet, so it sounds not worth
to do the trouble.
To solve 1, 2 and 3, I'd like to kill my original test code... :)
dlls/user32/tests/winstation.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 447 bytes
Desc: not available
More information about the wine-patches