[PATCH 2/2] user32/tests: Skip a test to avoid wineserver desktop manager bug.
Qian Hong
qhong at codeweavers.com
Sat Nov 9 03:52:58 CST 2013
Hello,
There are three reasons to introduce this patch:
1.
The original motivation of test_foregroundwindow() is to test
OpenInputDesktop() and SwitchDesktop(), especially for testing the
latter. However, according to recently discussion in wine-devel [1], it
is imposible to implement SwitchDesktop() in Wine correctly, so this
test doesn't make too much sense, especially after "user32: Implement
OpenInputDesktop." [2] has been committed.
2.
Currently, this patch causes randomly failures on some Windows versions,
mostly like related to sleeping time, which can't be reproduced when run
the test standalonely [3]. It is possible to fix the failures by
submitting a patch which increase sleeping time, but it doesn't make too
much sense according to point 1.
3.
This patch discovered a wineserver bug: wineserver desktop manager
doesn't count thread as user, it just count process as user.
To fix this bug, we have to modify some wineserver code, but I haven't
found any real world app affects by this bug yet, so it sounds not worth
to do the trouble.
To solve 1, 2 and 3, I'd like to kill my original test code... :)
[1] http://www.winehq.org/pipermail/wine-devel/2013-October/101820.html
[2]
http://source.winehq.org/git/wine.git/commit/f7835dea2ddbd3aa8fb53fb4b83ccaf16f5efde9
[3] https://test.winehq.org/data/tests/user32:winstation.html
---
dlls/user32/tests/winstation.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-user32-tests-Skip-a-test-to-avoid-wineserver-desktop-m.txt
Type: text/x-patch
Size: 447 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20131109/f1393da9/attachment.bin>
More information about the wine-patches
mailing list