testbot: Disable support for taking screenshots.

Francois Gouget fgouget at codeweavers.com
Sat Oct 5 18:36:03 CDT 2013


This does not work with the current WineTestBot configuration and causes libvirt connections to be leaked.
---

The libvirt library on the WineTestBot server is too old which breaks 
taking screenshots. In the meantime attempts to take screenshots cause a 
libvirt connection to be leaked so in the end the libvirtd client limit 
is reached. So disable taking screenshots until the WineTestBot server 
can be upgraded.


 testbot/lib/WineTestBot/VMs.pm | 3 +++
 testbot/web/JobDetails.pl      | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm
index 5913f2c..7c403cd 100644
--- a/testbot/lib/WineTestBot/VMs.pm
+++ b/testbot/lib/WineTestBot/VMs.pm
@@ -417,6 +417,9 @@ sub CaptureScreenImage($)
 {
   my ($self) = @_;
 
+  # FIXME: Disable screenshots for now
+  return ("Screenshotting has been disabled for the time being", undef, undef);
+
   my ($ErrMessage, $Domain) = $self->_GetDomain();
   return ($ErrMessage, undef, undef) if (defined $ErrMessage);
 
diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl
index 2e91f14..eba09eb 100644
--- a/testbot/web/JobDetails.pl
+++ b/testbot/web/JobDetails.pl
@@ -258,7 +258,8 @@ sub GenerateBody
     my $LogName = "$TaskDir/log";
     my $ErrName = "$TaskDir/err";
     print "<div class='TaskMoreInfoLinks'>\n";
-    if (($Item->Status eq "running" || $Item->Status eq "partway") &&
+    # FIXME: Disable live screenshots for now
+    if (0 && ($Item->Status eq "running" || $Item->Status eq "partway") &&
         ($Item->Type eq "single" || $Item->Type eq "suite"))
     {
       if (defined($self->GetParam($ScreenshotParamName)))
-- 
1.8.4.rc3



More information about the wine-patches mailing list