[5/5] kernel32/tests: Always allow only one correct test result, add todo_wine where necessary.

Sebastian Lackner sebastian at fds-team.de
Thu Aug 21 06:43:59 CDT 2014


NOTE: This patch can be seen as a RFC, I'm also open for other suggestions how to solve that. It might lead to additional _test failures_ on some platforms!

Some of the existing tests decide between 'ok(...)' and 'todo_wine ok(...)' based on the test result. This means its nearly impossible to break those tests, and regressions remain unnoticed. I would suggest to solve this issue by removing all the complicated if(...) checks, and instead just define one specific system, where it should work. The following patch assumes a Linux system with kernel >= 1.7.12, which is hopefully similar to what Julliard uses on his development machines (If not I can also fix that). If we still have the intention to mark really all broken tests as todo, we will have to add additional methods to report the version of the underlying operating system to the wine tests, instead of deciding based on the test result (for each call individually).

---
 dlls/kernel32/tests/pipe.c |   46 +++++++++++---------------------------------
 1 file changed, 11 insertions(+), 35 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-kernel32-tests-Always-allow-only-one-correct-test-re.patch
Type: text/x-patch
Size: 6493 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20140821/1b80c971/attachment.bin>


More information about the wine-patches mailing list