[2/2] winemenubuilder: ignore icons in unsupported PNG format

Indrek Altpere efbiaiinzinz at hotmail.com
Thu Aug 28 11:09:48 CDT 2014


While fixing https://bugs.winehq.org/show_bug.cgi?id=19241 I saw that
winemenubuilder does not handle/ignore png icon entries currently.

As per MSDN blog, icon resources can contain raw PNG information instead of
regular BITMAPINFO, but due to weird decisions, only way to differentiate
between them is to check if the resource starts with PNG header bytes.
http://blogs.msdn.com/b/oldnewthing/archive/2010/10/22/10079192.aspx
Made the winemenubuilder ignore such entries for now (with fixme notices),
since using PNG raw bytes as BITMAPINFO data is definitely invalid and is
due to cause other issues/crashes when the best matching size icon happens
to be PNG. A new bug should be opened for the missing PNG support.

Regards,
Indrek
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: winemenubuilder_2_png.txt
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20140828/f9eb0c8c/attachment.txt>


More information about the wine-patches mailing list