msi: Fix the usage of toupper() (PVS-Studio)

Michael Stefaniuc mstefani at redhat.de
Wed Dec 10 03:41:07 CST 2014


The alternate fix would be to remove that call altogether as it is a
no-op at the moment.
---
 dlls/msi/action.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 1e527da..e09850b 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -2423,7 +2423,7 @@ static UINT ACTION_CostFinalize(MSIPACKAGE *package)
                     sprintfW( buf, fmtW, free.QuadPart / 512 );
                     msi_set_property( package->db, szPrimaryVolumeSpaceAvailable, buf, -1 );
                 }
-                toupperW( primary_folder[0] );
+                primary_folder[0] = toupperW( primary_folder[0] );
                 msi_set_property( package->db, szPrimaryVolumePath, primary_folder, 2 );
             }
             msi_free( primary_folder );
-- 
1.9.3



More information about the wine-patches mailing list