shell32: Correct create flags when SEE_MASK_NO_CONSOLE isn't specified

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Thu Jan 23 22:57:16 CST 2014


Hi,
 From MSDN
"*SEE_MASK_NO_CONSOLE* (0x00008000)

    Use to inherit the parent's console for the new process instead of
    having it create a new console. It is the opposite of using a
    CREATE_NEW_CONSOLE flag with *CreateProcess*
    <http://msdn.microsoft.com/en-us/library/windows/desktop/ms682425%28v=vs.85%29.aspx>."


Changelog:
       shell32: Correct create flags when SEE_MASK_NO_CONSOLE isn't 
specified


Best Regards
   Alistair Leslie-Hughes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20140124/59046b59/attachment.html>
-------------- next part --------------
>From 692147c3abf9ab1b49425f6c7ce0cbe7e572ae80 Mon Sep 17 00:00:00 2001
From: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date: Fri, 24 Jan 2014 15:31:31 +1100
Subject: [PATCH] Correct create flags when SEE_MASK_NO_CONSOLE isn't specified
To: wine-patches <wine-patches at winehq.org>

---
 dlls/shell32/shlexec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c
index 39d640a..9f6698a 100644
--- a/dlls/shell32/shlexec.c
+++ b/dlls/shell32/shlexec.c
@@ -338,7 +338,7 @@ static UINT_PTR SHELL_ExecuteW(const WCHAR *lpCmd, WCHAR *env, BOOL shWait,
     startup.dwFlags = STARTF_USESHOWWINDOW;
     startup.wShowWindow = psei->nShow;
     dwCreationFlags = CREATE_UNICODE_ENVIRONMENT;
-    if (psei->fMask & SEE_MASK_NO_CONSOLE)
+    if ( !(psei->fMask & SEE_MASK_NO_CONSOLE) )
         dwCreationFlags |= CREATE_NEW_CONSOLE;
     if (CreateProcessW(NULL, (LPWSTR)lpCmd, NULL, NULL, FALSE, dwCreationFlags, env,
                        lpDirectory, &startup, &info))
-- 
1.8.3.2



More information about the wine-patches mailing list