[PATCH] kernel32: fixed 1 entry overread overflow (Coverity)

Marcus Meissner marcus at jet.franken.de
Tue Jul 15 01:52:41 CDT 2014


1225843 Out-of-bounds read
---
 dlls/kernel32/locale.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c
index f803155..e9b08c5 100644
--- a/dlls/kernel32/locale.c
+++ b/dlls/kernel32/locale.c
@@ -4472,7 +4472,7 @@ INT WINAPI GetGeoInfoW(GEOID geoid, GEOTYPE geotype, LPWSTR data, int data_len,
     TRACE("%d %d %p %d %d\n", geoid, geotype, data, data_len, lang);
 
     /* validate index */
-    if (geoid < 0 || geoid > sizeof(geoinfodata)/sizeof(struct geoinfo_t)) {
+    if (geoid < 0 || geoid >= sizeof(geoinfodata)/sizeof(struct geoinfo_t)) {
         SetLastError(ERROR_INVALID_PARAMETER);
         return 0;
     }
-- 
1.8.4.5




More information about the wine-patches mailing list