libwine: Added wine_dbgstr_variant and wine_dbgstr_vt implementations.

Jacek Caban jacek at codeweavers.com
Tue Jul 22 12:16:01 CDT 2014


This is meant to remove all the duplicated debugstr_variant
implementations. While this is ugly, mostly due to duplicated
declarations, this is the most straightforward solution. An alternative
would be to implement this in ntdll (using __wine_debug_functions). This
would avoid headers problem (well, it's still ugly to use oaidl.h in
ntdll, but technically allowed) and allow exception protection, like
string printing functions. I'm not sure if that's better. I'm ready to
change the patch.

I will add short winedbg_variant alias and remove all the duplications
once the main patch is committed.

---
 dlls/oleaut32/variant.c | 108 +--------------------
 include/wine/debug.h    |   4 +
 libs/wine/debug.c       | 251
++++++++++++++++++++++++++++++++++++++++++++++++
 libs/wine/wine.def      |   2 +
 libs/wine/wine.map      |   2 +
 5 files changed, 261 insertions(+), 106 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libwine-Added-wine_dbgstr_variant-and-wine_dbgstr_vt-.diff
Type: text/x-patch
Size: 14739 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20140722/5c8ff066/attachment.bin>


More information about the wine-patches mailing list