[PATCH] mscoree: Fixed use after free (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun Jul 27 04:19:54 CDT 2014


1102538 Use after free
---
 dlls/mscoree/corruntimehost.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/mscoree/corruntimehost.c b/dlls/mscoree/corruntimehost.c
index b0a8b9d..33b76ff 100644
--- a/dlls/mscoree/corruntimehost.c
+++ b/dlls/mscoree/corruntimehost.c
@@ -1403,12 +1403,13 @@ HRESULT create_monodata(REFIID riid, LPVOID *ppObj )
 
             filenameA = WtoA(filename);
             assembly = mono_domain_assembly_open(domain, filenameA);
-            HeapFree(GetProcessHeap(), 0, filenameA);
             if (!assembly)
             {
                 ERR("Cannot open assembly %s\n", filenameA);
+                HeapFree(GetProcessHeap(), 0, filenameA);
                 goto cleanup;
             }
+            HeapFree(GetProcessHeap(), 0, filenameA);
 
             image = mono_assembly_get_image(assembly);
             if (!image)
-- 
1.8.4.5




More information about the wine-patches mailing list