quartz: Destroy BaseRenderer in NullRendererInner_Release.

Thomas Faber thomas.faber at reactos.org
Tue Jul 29 02:23:41 CDT 2014


NullRenderer inherits from BaseRenderer, not just BaseFilter.
Fixes leak of the BaseRenderer members.
-------------- next part --------------
From aa838907bc78b1fe0d85dc93dfb87cc8b7f5ea19 Mon Sep 17 00:00:00 2001
From: Thomas Faber <thomas.faber at reactos.org>
Date: Mon, 28 Jul 2014 12:10:01 +0200
Subject: quartz: Destroy BaseRenderer in NullRendererInner_Release.

---
 dlls/quartz/nullrenderer.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/quartz/nullrenderer.c b/dlls/quartz/nullrenderer.c
index 7befc46..dbbdd4f 100644
--- a/dlls/quartz/nullrenderer.c
+++ b/dlls/quartz/nullrenderer.c
@@ -128,12 +128,11 @@ static ULONG WINAPI NullRendererInner_AddRef(IUnknown *iface)
 static ULONG WINAPI NullRendererInner_Release(IUnknown *iface)
 {
     NullRendererImpl *This = impl_from_IUnknown(iface);
-    ULONG refCount = InterlockedDecrement(&This->renderer.filter.refCount);
+    ULONG refCount = BaseRendererImpl_Release(&This->renderer.filter.IBaseFilter_iface);
 
     if (!refCount)
     {
         TRACE("Destroying Null Renderer\n");
-        BaseFilter_Destroy(&This->renderer.filter);
         CoTaskMemFree(This);
     }
 
-- 
1.9.0.msysgit.0



More information about the wine-patches mailing list