msvcrt: Fix potential int overflow in quick_sort function (try 2)

Frédéric Delanoy frederic.delanoy at gmail.com
Wed Jun 11 19:33:59 CDT 2014


---
 dlls/msvcrt/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msvcrt/misc.c b/dlls/msvcrt/misc.c
index 36d0608..fee5ca1 100644
--- a/dlls/msvcrt/misc.c
+++ b/dlls/msvcrt/misc.c
@@ -281,7 +281,7 @@ static void quick_sort(void *base, MSVCRT_size_t nmemb, MSVCRT_size_t size,
 
         lo = beg;
         hi = end;
-        med = (hi+lo+1)/2;
+        med = lo + (hi-lo+1)/2; /* avoid potential int overflow */
         if(compar(context, X(lo), X(med)) > 0)
             swap(X(lo), X(med), size);
         if(compar(context, X(lo), X(hi)) > 0)
-- 
2.0.0




More information about the wine-patches mailing list