Revert "windowscodecs: Fix leak in test_QueryCapability."

Vincent Povirk madewokherd at gmail.com
Thu Jun 19 14:48:20 CDT 2014


This breaks the tests on Windows, where a previous call fails, meaning
we don't have a valid pointer to release.

I sent a fixed version, but the broken version was committed in
addition to the fixed one. So now on Wine the leak is double-fixed,
which probably also breaks the test.
-------------- next part --------------
From 7bb17ef7566c23b223173fd293ac364d10082668 Mon Sep 17 00:00:00 2001
From: Vincent Povirk <vincent at codeweavers.com>
Date: Thu, 19 Jun 2014 14:43:46 -0500
Subject: [PATCH] Revert "windowscodecs: Fix leak in test_QueryCapability."

This reverts commit 0f2efcf0c528f9c6b831e5f13d495a26a38734e9.
---
 dlls/windowscodecs/tests/tiffformat.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dlls/windowscodecs/tests/tiffformat.c b/dlls/windowscodecs/tests/tiffformat.c
index cee8882..cc1951e 100644
--- a/dlls/windowscodecs/tests/tiffformat.c
+++ b/dlls/windowscodecs/tests/tiffformat.c
@@ -242,8 +242,6 @@ todo_wine
     hr = IStream_Seek(stream, pos, SEEK_SET, NULL);
     ok(hr == S_OK, "IStream_Seek error %#x\n", hr);
 
-    IWICBitmapDecoder_Release(decoder);
-
     hr = IWICImagingFactory_CreateDecoderFromStream(factory, stream, NULL, 0, &decoder);
     ok(hr == S_OK, "CreateDecoderFromStream error %#x\n", hr);
 
-- 
1.8.3.2



More information about the wine-patches mailing list